kmesh-net / website

Kmesh website and documentation repo
https://kmesh.net
Creative Commons Attribution 4.0 International
2 stars 10 forks source link

docs(quickstart): should create namespace before apply yaml files #40

Closed Okabe-Rintarou-0 closed 1 month ago

Okabe-Rintarou-0 commented 1 month ago

In quickstart, if we directly apply yaml files, it will raise namespace-not-found errors. It'd be better if we add create namespace command.

image

kmesh-bot commented 1 month ago

Welcome @Okabe-Rintarou-0! It looks like this is your first PR to kmesh-net/website 🎉

netlify[bot] commented 1 month ago

Deploy Preview for kmesh-net ready!

Name Link
Latest commit e6b564b4473abfc0276578fedf01d8728bea0c18
Latest deploy log https://app.netlify.com/sites/kmesh-net/deploys/6646e1681bbdc600086aa6ba
Deploy Preview https://deploy-preview-40--kmesh-net.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nlgwcy commented 1 month ago

Thanks for your participation. FYI, if the namespace can be automatically created when the YAML is applied, better user experience may be provided. You can add the YAML created the namespace in the kmesh code repository, for details:

apiVersion: v1
kind: Namespace
metadata:
   name: kmesh-system
Okabe-Rintarou-0 commented 1 month ago

Thanks for your participation. FYI, if the namespace can be automatically created when the YAML is applied, better user experience may be provided. You can add the YAML created the namespace in the kmesh code repository, for details:

apiVersion: v1
kind: Namespace
metadata:
   name: kmesh-system

sure, i can create a pr in kmesh for that

kmesh-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kmesh-net/website/blob/main/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment