search

kmfarley11 / version-checker

Keep tabs on all hardcoded versions in your code
MIT License
0 stars 0 forks source link

Handle non-unique json versions #15

Open kmfarley11 opened 3 years ago

kmfarley11 commented 3 years ago

Json doesn't implicitly support comments. Since bump2version just does raw string comparisons, this can make unique matching difficult in npm package files etc.

It seems a bit grand in scope, but we could potentially use actual regex or actual json parsing to resolve json versions and do updating on the version_checker side.

kmfarley11 commented 3 years ago

this honestly might be reason enough to decouple from bump2version and just do it ourselves via regex...

kmfarley11 commented 3 years ago

looking at npm's versioning tool: https://docs.npmjs.com/cli/v7/commands/npm-version#configuration

maybe users could just tag a specific --preid and match based on that 🤔