search

kmfarley11 / version-checker

Keep tabs on all hardcoded versions in your code
MIT License
0 stars 0 forks source link

be more integrator-friendly #7

Open kmfarley11 opened 3 years ago

kmfarley11 commented 3 years ago

The functions in utils.py often implicitly do a sys.exit(1) (_error()...)

This is unkind to those that'd want to use these imports. Default to returning an empty string or false or something, then have the cli detect the return and exit for us...

kmfarley11 commented 3 years ago

Should also add a --version in the argparse...

kmfarley11 commented 3 years ago

Probably should've named this issue differently, bcoming a refactor bucket. Anyways, consider adding type-hinting to public methods while in here