Open Paul-Huntsberry opened 7 years ago
Agreed! I couldn't figure out why sometimes I just wouldn't see SpotMenu in my menu bar. My theory is that when {{Artist}} - {{Song}} is too long it is just straight up not displayed. Fixed width with scrolling would also be my suggestion.
Screenshots below: Chrome has more menu items than Spotify does so a long title appears when on Spotify App but not on Chrome
Yes that's an OS feature, I've noticed it myself. I've gotten used to it. Scrolling would indeed be nice. I don't know how easy it would be to implement though, since I haven't found any open source libraries for scrolling labels for macOS I've only seen them for iOS. I've been busy lately and haven't had time to deal with issues.
Scrolling might be difficult to implement but it would be nice if it only dropped the song title/artist when necessary and kept the spotify icon. That way the app is still accessible during songs with long titles.
This could also be great for the widget in the Notification Center or the menu bar when hovering over the album art.
Something like that ? https://github.com/cbpowell/MarqueeLabel
@fabi94music Yes that's almost exactly what I was thinking of.
@fabi94music how would i implement that to the app?
Unfortunately I don't know.... :( I saw this recently and thought it could help but I'm not a programmer 🙈
@fabi94music awh.. it looks complicated aha i need help xD did you get it too?
this is what i'm working on, there's still a long way to go. any help would be appreciated
I have created this class for my own project if you would like to take a look at implementing this view. https://gist.github.com/NicholasBellucci/b5e9d31c47f335c36aa043f5f39eedb2
Disclaimer: This is an NSView that is added to the content view in the window of the NSStatusItem by accessing statusItem.value(forKey: "window") as? NSWindow
.
Looks amazing 🙌🏻 Thank you for this. I was thinking I should add it to the PopOver.xib
for starters. Adding it to statusItem.value(forKey: "window") as? NSWindow
is probably going to take more time since I want it to work with the SpotMenu icon and now playing symbol (♬) seamlessly.
So the feather icon that is next to the text is also part of my project. It is all added to statusItem.value(forKey: "window") as? NSWindow
. One is an NSImageView while the other is the scrolling text view. I haven't looked into how you set SpotMenu up in the menubar but this is what mine looks like clicked. I didn't use interface builder however.
I will look into making a PR.
Let me know what you think and Ill look into making the PR. Threw it together pretty quickly. More needs to be done to make sure everything works but I could look into all of it.
Looks good, but the music icon there is for indicating the music is played on iTunes
😬
Spotify:
iTunes:
This, currently is just a unicode character
Also, if highlighting works correctly both in light and dark mode on macos (white text on blue background), then that would be amazing
Yea I know. Logic has to be put in place to do what you were doing before, I just don't have too much time right now but I will later. Your comment helps though. And highlighting works full and it still scrolls when highlighted.
I had more time than I thought. Works for iTunes as well.
Playing
Popover
Pausing
Hi, I created a pull request that lets the user define their own maximum width, that way the user can decide how much space should be used at max . Have a look here: https://github.com/kmikiy/SpotMenu/pull/207 Cheers!
This app is excellent so far. I would recommend dropping the multiple icons in menubar (or giving choice to show or not) and then having a maximum width for the text in the menubar and then let it scroll the name of the artist - song text within a customized character limit. This way if you have the song name is too long, it won't take up so much of the menu bar.