kmikiy / SpotMenu

Spotify and iTunes in your menu bar
https://kmikiy.github.io/SpotMenu
MIT License
2.94k stars 185 forks source link

Scrolling text for artist - track title #16

Open Paul-Huntsberry opened 7 years ago

Paul-Huntsberry commented 7 years ago

This app is excellent so far. I would recommend dropping the multiple icons in menubar (or giving choice to show or not) and then having a maximum width for the text in the menubar and then let it scroll the name of the artist - song text within a customized character limit. This way if you have the song name is too long, it won't take up so much of the menu bar.

cwaldau commented 7 years ago

Agreed! I couldn't figure out why sometimes I just wouldn't see SpotMenu in my menu bar. My theory is that when {{Artist}} - {{Song}} is too long it is just straight up not displayed. Fixed width with scrolling would also be my suggestion.

Screenshots below: Chrome has more menu items than Spotify does so a long title appears when on Spotify App but not on Chrome

screen shot 2017-04-24 at 8 04 56 pm screen shot 2017-04-24 at 8 05 10 pm
kmikiy commented 7 years ago

Yes that's an OS feature, I've noticed it myself. I've gotten used to it. Scrolling would indeed be nice. I don't know how easy it would be to implement though, since I haven't found any open source libraries for scrolling labels for macOS I've only seen them for iOS. I've been busy lately and haven't had time to deal with issues.

Raab70 commented 7 years ago

Scrolling might be difficult to implement but it would be nice if it only dropped the song title/artist when necessary and kept the spotify icon. That way the app is still accessible during songs with long titles.

ghost commented 7 years ago

This could also be great for the widget in the Notification Center or the menu bar when hovering over the album art.

ghost commented 6 years ago

Something like that ? https://github.com/cbpowell/MarqueeLabel

Raab70 commented 6 years ago

@fabi94music Yes that's almost exactly what I was thinking of.

frxncesdanielle commented 6 years ago

@fabi94music how would i implement that to the app?

ghost commented 6 years ago

Unfortunately I don't know.... :( I saw this recently and thought it could help but I'm not a programmer 🙈

frxncesdanielle commented 6 years ago

@fabi94music awh.. it looks complicated aha i need help xD did you get it too?

kmikiy commented 6 years ago

ezgif-2-992c3106da

this is what i'm working on, there's still a long way to go. any help would be appreciated

NicholasBellucci commented 5 years ago

I have created this class for my own project if you would like to take a look at implementing this view. https://gist.github.com/NicholasBellucci/b5e9d31c47f335c36aa043f5f39eedb2

demo

Disclaimer: This is an NSView that is added to the content view in the window of the NSStatusItem by accessing statusItem.value(forKey: "window") as? NSWindow.

kmikiy commented 5 years ago

Looks amazing 🙌🏻 Thank you for this. I was thinking I should add it to the PopOver.xib for starters. Adding it to statusItem.value(forKey: "window") as? NSWindow is probably going to take more time since I want it to work with the SpotMenu icon and now playing symbol (♬) seamlessly.

NicholasBellucci commented 5 years ago

So the feather icon that is next to the text is also part of my project. It is all added to statusItem.value(forKey: "window") as? NSWindow. One is an NSImageView while the other is the scrolling text view. I haven't looked into how you set SpotMenu up in the menubar but this is what mine looks like clicked. I didn't use interface builder however.

screen shot 2018-11-08 at 9 57 46 am

NicholasBellucci commented 5 years ago

I will look into making a PR.

NicholasBellucci commented 5 years ago

ezgif-5-00f8856f1f9f

Let me know what you think and Ill look into making the PR. Threw it together pretty quickly. More needs to be done to make sure everything works but I could look into all of it.

kmikiy commented 5 years ago

Looks good, but the music icon there is for indicating the music is played on iTunes 😬

Spotify:

screen shot 2018-11-08 at 4 33 48 pm

iTunes:

screen shot 2018-11-08 at 4 34 15 pm

This, currently is just a unicode character

screen shot 2018-11-08 at 4 35 28 pm

Also, if highlighting works correctly both in light and dark mode on macos (white text on blue background), then that would be amazing

screen shot 2018-11-08 at 4 32 04 pm
NicholasBellucci commented 5 years ago

Yea I know. Logic has to be put in place to do what you were doing before, I just don't have too much time right now but I will later. Your comment helps though. And highlighting works full and it still scrolls when highlighted.

NicholasBellucci commented 5 years ago

I had more time than I thought. Works for iTunes as well.

Playing ezgif-5-5de3553fe639

Popover ezgif-5-6083bac39e17

Pausing ezgif-5-4703a3bcc3c9

JakobFelixJulius commented 5 years ago

Hi, I created a pull request that lets the user define their own maximum width, that way the user can decide how much space should be used at max . Have a look here: https://github.com/kmikiy/SpotMenu/pull/207 Cheers! ScreenRecording2019-10-01at14115