search

kmille / deezer-downloader

Download music from Deezer with a nice front end
MIT License
652 stars 91 forks source link

Add FLAC support #111

Open 10p3 opened 6 months ago

10p3 commented 6 months ago

I've used this to download a couple of playlists and it seems to work so far (using the free trial). It'd be good if someone could test that it doesn't break operation with free accounts since i don't currently have one. I've yet to observe any songs with AAC as an option so the change to the "exists already" check doesn't handle that yet. I'm not sure how robust the error handling is if the server returns results in an unexpected format.

The web client gets media urls with a seperate API call using TRACK_TOKEN from the song data, the encryption on FLACs seems unchanged. Some songs have a "Fallback" to a different ID and do not allow downloads using the original id, this is currently handled after failing on the original file but it might be worth not trying the original if a fallback is supplied.

mryan43 commented 5 months ago

Small comment to mention that I have tested this (with a non-free account) and it works for me ! thanks a lot !

kmille commented 5 days ago

sorry for not taking care :( Currently don't have time for it. There was something I didn't like - I think it was just renameing mp3 to flac file ending...

10p3 commented 5 days ago

I'm not sure I understand. Is there something I could do to help fix it? I don't have a premium account to test with at the moment but it definitely was working with a playlist I tried when I wrote it. image

kmille commented 5 days ago

yea, thanks for the PR. I just need some time for this.

kito30 commented 1 day ago

it seems that for me, I can only download 128kbps not 320