Add chords visuals - Githubissues

kmille / freetar

freetar - an alternative frontend to ultimate-guitar.com

GNU General Public License v3.0

626 stars 26 forks source link

Add chords visuals #4

Closed nealonhager closed 9 months ago

nealonhager commented 10 months ago

Would be happy to run a formatter over this if you could share your config for the project.

kmille commented 10 months ago

Hey, thanks! I think it's nice to have the visualization, but I'm still not sure about how it should look like. It takes a lot of space. Some ideas:

maybe a switch like the Autoscroll feature has to show/hide the visualization
different versions of a chord is shown. Most of the time, this is unnecessary

If I compare the current version with the one of UG, I prefer the UG version.

nealonhager commented 10 months ago

totally agree, this was more of an iterative change towards a solution and not the full solution. Will update to be more complete

nealonhager commented 10 months ago

@kmille made it match closer to the UG version. But it doesn't have chord variants at the moment. Is that something you would like to be added? I was unsure based on your second point, either way I think this is an improvement to the current version and should be added.

kmille commented 10 months ago

Looks much better! Can you copy the "Autoscroll" button and only show the chords if the switch is enabled?

nealonhager commented 10 months ago

@kmille added, with the default being off

kmille commented 9 months ago

Really cool, thanks!

kmille commented 9 months ago

I tried to get the two switches and other controls in one line. But I just failed... Can you get it done...?

nealonhager commented 9 months ago

I can look into that!