search

kmisztal / KiMage

Java Image Processing Library
6 stars 12 forks source link

Feature/cleanup1 #2

Closed KonradAdamek closed 8 years ago

KonradAdamek commented 8 years ago

Cleanup, little refactor, code style. Switch replaced by polymorphism.

Not a big deal.

dkrawiec commented 8 years ago

I would wait with this changes, as I would like to discuss tomorrow how we should proceed with the refactoring.

annaskulimowska commented 8 years ago

I like the rule says "Each comma or conjunction in commit message says that the commit should be broken into multiple parts". I think that minor changes should be in the hands of people who are just starting to write in Java. Now we need fundamental changes. A commit message should say exactly what changed. "Switch replaced by polymorphism" for me it's ok (I think even better would be to add where it has been changed), but "Cleanup, little refactor, code style." says nothing. I also think it's better to give up the polymorphism where possible (because of the increased memory consumption)