search

kmisztal / KiMage

Java Image Processing Library
6 stars 12 forks source link

Implement Image class #30

Closed tomczylok closed 8 years ago

tomczylok commented 8 years ago

26

dkrawiec commented 8 years ago

Extract color abstraction to another class.

dkrawiec commented 8 years ago

I think it would be nice to provide builder for Image class so that you don't have to provide array of Color on your own.

dkrawiec commented 8 years ago

I guess we need another implementation of a Color class. Which is GrayscaleColor.

Actually we could extend the approach with static fields to a flyweight design pattern, since this class is immutable, and actually a value object.

kmisztal commented 8 years ago

ok

dkrawiec commented 8 years ago

@tomczylok please fix mentioned issues and open another pull request, this time to master.