search

kmisztal / KiMage

Java Image Processing Library
6 stars 12 forks source link

73 sepia plugin #85

Closed kondratowiczm closed 8 years ago

dkrawiec commented 8 years ago

Looks fine. Would it be possible to add unit tests?

kondratowiczm commented 8 years ago

Might be difficult, different tools uses different sepia settings so it would be hard to compare result of this filter with filter from any other library and counting this manually does not sound good.

dkrawiec commented 8 years ago

Yeah, but writing assertions for small case like 2x2 with expected values will still be better than nothing.

kondratowiczm commented 8 years ago

I can calculate expected values for case 2x2 but I don't know how to test those steps and rest of things

dkrawiec commented 8 years ago

Work will be continued in dedicated feature branch in KiMage repository https://github.com/kmisztal/KiMage/tree/73-sepia-plugin