search

kmitgroup / google-checkout-php-sample-code

Automatically exported from code.google.com/p/google-checkout-php-sample-code
0 stars 0 forks source link

button code not passing W3C validation [patch for PHP] #49

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I am a code neatness freak by nature, and make sure my pages contain no
validation errors. So imagine my surprise when the PHP API's buttons
generated errors.

Steps to reproduce:

1. Generate a page with a checkout button on it
2. Pass that page to http://validator.w3.org/

I'm using the PHP API, version 1.2.5b/c on Linux with Apache 2.2.13+PHP 5.2.11.

Mostly it was errors having with '&''s not being output as '&', but
there were also some problems with the input type=image tags.

So I've played around with the code and written a patch. Feel free to
use/publish however.

Original issue reported on code.google.com by amphetam...@gmail.com on 18 Jan 2010 at 4:43

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi,

Will it work on javascript pages?

http://www.carazoo.com/

Original comment by carazoo...@gmail.com on 16 Feb 2010 at 5:25

GoogleCodeExporter commented 9 years ago 
It affects the HTML code that is output by the button generation functions. It 
should
work on any page that uses them.

Original comment by amphetam...@gmail.com on 17 Feb 2010 at 6:08

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Please pay no mind to lizadecausta, as it is just a spammer.

Original comment by amphetam...@gmail.com on 30 May 2010 at 4:51

GoogleCodeExporter commented 9 years ago 
Ofcourse and it will work at javascript pages...what a question???:)

http://www.mytorrentz.tv

Original comment by antwnako...@gmail.com on 2 Jul 2010 at 10:18

GoogleCodeExporter commented 9 years ago 
antwnakos.antwnakos: just another spammer

Original comment by amphetam...@gmail.com on 6 Jul 2010 at 5:54

GoogleCodeExporter commented 9 years ago

Original comment by peng.y...@gmail.com on 7 Jul 2010 at 10:23

GoogleCodeExporter commented 9 years ago 
fixed

Original comment by peng.y...@gmail.com on 13 Sep 2010 at 11:40