search

kmiyashiro / grunt-mocha

[MOVED] Grunt task for running mocha specs in a headless browser (PhantomJS)
MIT License
369 stars 106 forks source link

Bump grunt-lib-phantomjs to ^1.0.0 #157

Closed wrumsby closed 8 years ago

wrumsby commented 8 years ago

This version brings in Phantom 2.1 which provides better support for ES5 features, including Function.prototype.bind which wasn't supported in Phantom 1.9.

kmiyashiro commented 8 years ago

Cool, this will go into the 1.0 release

BYK commented 8 years ago

Any news about this or the 1.0 release?

kmiyashiro commented 8 years ago

Hey guys, I have a branch for this here: https://github.com/kmiyashiro/grunt-mocha/tree/bump-phantom

Unfortunately, it's breaking the xunit file output test and I don't have time at the moment to investigate more. If anyone wants to investigate the cause, that would be a big help.

BYK commented 8 years ago

@kmiyashiro - thanks for the update! I'm willing to give a hand with this so I'll checkout the branch and see if I can fix it.

td-edge commented 8 years ago

+1

BYK commented 8 years ago

Okay, I got this working. I had to use latest master instead of the published 1.0.1 version of grunt-phantomjs since it had an important fix that prevented our tests from failing randomly.