search

kmjennison / dfp-prebid-setup

Automated line item generator for Prebid.js and Google Ad Manager
MIT License
120 stars 75 forks source link

Support run-of-network line items (no targeted placements) #16

Open ptomasroos opened 7 years ago

ptomasroos commented 7 years ago 
dfp.exceptions.BadSettingException: The setting "DFP_TARGETED_PLACEMENT_NAMES" must contain at least one DFP placement ID.

IMHO this should default to Run of network in the case of empty array not yield a error. On our case I see exactly no reason to have this targeted against specific placements, or adunits the reason is that one needs to generate many more than just having 1 per bidder which runs for all adunits.

kmjennison commented 7 years ago

This makes sense.

When we add this feature, I'd like to protect people who blindly run the script without configuring settings properly, because I believe the most common use case is to target to placements. We could safeguard by adding DFP_ALLOW_NO_INVENTORY_TARGETING that defaults to false.

@ptomasroos Interested in contributing this?

ptomasroos commented 7 years ago

Thanks for fixen the issues btw @kmjennison, I hacked it locally, will clean up and send a PR in a week or two

kevinlisota commented 7 years ago

@ptomasroos do you have that PR ready or a sample of what you did? We need run of network as well, not specific adunits or placements. This could save me many hours of tedious work :)

pboisso commented 7 years ago

I'd be interested in Run of Network also, does anyone managed to get it done? Thanks!