kmkatsma / angular2-webpack-starter-gentelella

Updated angular2-webpack-starter modified to support the open source gentelella theme
149 stars 96 forks source link

Migration to Angular 5 / Webpack 3 / Bootstrap 4 Beta 2 #6

Closed pihomeserver closed 5 years ago

pihomeserver commented 6 years ago

Dear all I would like to use Gentelella in an Angular 5 project to be up to date. Then i cloned the repo, and upgraded all packages to latest version in particular for Angular, Bootstrap and Webpack I was able to solve many issues by updating many configuration files but i'm stucked in a strange behavior. Webpack tries to compile e2e.ts files and generates errors (last ones ?) :

ERROR in ./src/app/app.component.ts
Module not found: Error: Can't resolve 'style' in '/home/chris/Kupiki-Hotspot-Admin-Frontend/src/app'
BREAKING CHANGE: It's no longer allowed to omit the '-loader' suffix when using loaders.
                 You need to specify 'style-loader' instead of 'style',
                 see https://webpack.js.org/guides/migrating/#automatic-loader-module-name-extension-removed
 @ ./src/app/app.component.ts 7:0-117
 @ ./src/app/app.module.ts
 @ ./src/app/index.ts
 @ ./src/main.browser.ts
 @ multi (webpack)-dev-server/client?http://localhost:3000 ./src/main.browser.ts

ERROR in [at-loader] ./src/app/app.e2e.ts:4:5
    TS2304: Cannot find name 'browser'.

ERROR in [at-loader] ./src/app/app.e2e.ts:9:19
    TS2304: Cannot find name 'browser'.

ERROR in [at-loader] ./src/app/app.e2e.ts:15:19
    TS2552: Cannot find name 'element'. Did you mean 'Element'?

ERROR in [at-loader] ./src/app/app.e2e.ts:15:27
    TS2304: Cannot find name 'by'.

ERROR in [at-loader] ./src/app/app.e2e.ts:21:19
    TS2552: Cannot find name 'element'. Did you mean 'Element'?

ERROR in [at-loader] ./src/app/app.e2e.ts:21:27
    TS2304: Cannot find name 'by'.

ERROR in [at-loader] ./src/app/app.e2e.ts:27:19
    TS2552: Cannot find name 'element'. Did you mean 'Element'?

ERROR in [at-loader] ./src/app/app.e2e.ts:27:27
    TS2304: Cannot find name 'by'.

ERROR in [at-loader] ./src/app/app.spec.ts:19:16
    TS2339: Property 'url' does not exist on type 'App'.

ERROR in [at-loader] ./src/app/home/home.e2e.ts:5:5
    TS2304: Cannot find name 'browser'.

ERROR in [at-loader] ./src/app/home/home.e2e.ts:10:19
    TS2304: Cannot find name 'browser'.

ERROR in [at-loader] ./src/app/home/home.e2e.ts:16:19
    TS2304: Cannot find name 'element'.

ERROR in [at-loader] ./src/app/home/home.e2e.ts:16:27
    TS2304: Cannot find name 'by'.

ERROR in [at-loader] ./src/app/menu/sidebar.component.ts:42:44
    TS2559: Type '() => void' has no properties in common with type 'JQueryAnimationOptions'.

ERROR in [at-loader] ./src/app/menu/sidebar.component.ts:54:46
    TS2559: Type '() => void' has no properties in common with type 'JQueryAnimationOptions'.

ERROR in [at-loader] ./src/app/menu/sidebar.component.ts:79:44
    TS2559: Type '() => void' has no properties in common with type 'JQueryAnimationOptions'.

ERROR in [at-loader] ./src/app/menu/sidebar.component.ts:91:46
    TS2559: Type '() => void' has no properties in common with type 'JQueryAnimationOptions'.

ERROR in Template execution failed: TypeError: Cannot read property 'title' of undefined

ERROR in   TypeError: Cannot read property 'title' of undefined

  - index.html:76
    /home/chris/Kupiki-Hotspot-Admin-Frontend/src/index.html:76:33

  - index.html:93 ./node_modules/html-webpack-plugin/lib/loader.js!./src/index.html.module.exports
    /home/chris/Kupiki-Hotspot-Admin-Frontend/src/index.html:93:3

  - index.js:264
    [Kupiki-Hotspot-Admin-Frontend]/[html-webpack-plugin]/index.js:264:16

  - util.js:16 tryCatcher
    [Kupiki-Hotspot-Admin-Frontend]/[html-webpack-plugin]/[bluebird]/js/release/util.js:16:23

  - promise.js:512 Promise._settlePromiseFromHandler
    [Kupiki-Hotspot-Admin-Frontend]/[html-webpack-plugin]/[bluebird]/js/release/promise.js:512:31

  - promise.js:569 Promise._settlePromise
    [Kupiki-Hotspot-Admin-Frontend]/[html-webpack-plugin]/[bluebird]/js/release/promise.js:569:18

  - promise.js:606 Promise._settlePromiseCtx
    [Kupiki-Hotspot-Admin-Frontend]/[html-webpack-plugin]/[bluebird]/js/release/promise.js:606:10

  - async.js:138 Async._drainQueue
    [Kupiki-Hotspot-Admin-Frontend]/[html-webpack-plugin]/[bluebird]/js/release/async.js:138:12

  - async.js:143 Async._drainQueues
    [Kupiki-Hotspot-Admin-Frontend]/[html-webpack-plugin]/[bluebird]/js/release/async.js:143:10

  - async.js:17 Immediate.Async.drainQueues
    [Kupiki-Hotspot-Admin-Frontend]/[html-webpack-plugin]/[bluebird]/js/release/async.js:17:14

Any advices to move forward are welcome Once it works i will publish PR to allow this repo update

furqan-shakir commented 6 years ago

Hi, I want to use the newest version of angular with Gentelella, did the upgrade worked with you? please publish it if it does. it will be very helpfull

pihomeserver commented 6 years ago

Hello Nope.i gave up and switched to another theme (coreui)

kmkatsma commented 5 years ago

So this was inactive very long time, but I just updated to angular 7, and project is now based off of angular CLI. So probably you've moved on, but just thought I should respond and close all the issues =)