search

kmkurn / pytorch-crf

(Linear-chain) Conditional random field in PyTorch.
https://pytorch-crf.readthedocs.io
MIT License
935 stars 151 forks source link

Pytorch 1.2 Upgrade #104

Closed aravindMahadevan closed 1 year ago

aravindMahadevan commented 1 year ago

Description

Upgrade library to support Pytorch 1.2 which will enable us to Torchscript the forward and decode method.

kmkurn commented 1 year ago

Thanks for this. I have allowed the tests to run, and it seems they're all succeeding! Another thing left is then to update the minimum requirement in docs/index.rst to say PyTorch 1.2, then I think we can merge this.

kmkurn commented 1 year ago

I'm merging this despite the build error. The error seems caused by Python 3.6 that no longer exists in newer Ubuntu.