search

kmkurn / pytorch-crf

(Linear-chain) Conditional random field in PyTorch.
https://pytorch-crf.readthedocs.io
MIT License
935 stars 151 forks source link

Add TorchScript #116

Closed leejuyuu closed 3 weeks ago

leejuyuu commented 1 month ago

This is my attempt to address the reviews of #113 .

coveralls commented 1 month ago

Coverage Status

coverage: 100.0%. remained the same when pulling e8c852e9287b2b1df48dd3cf10ade2b27912db04 on leejuyuu:torchscriptable into cc449ebd5b162f13ba9663dcb32acc42c964d24c on kmkurn:master.

leejuyuu commented 4 weeks ago

@kmkurn I rebased this onto the master branch.

leejuyuu commented 3 weeks ago

I've split up the tests into smaller pieces. The commit messages are a bit messy, I think I'll squash them into one if it is ready to get merged.

kmkurn commented 3 weeks ago

I think this PR looks good to merge. If you still want to squash the commits into one, please do so now, and then let me know.

leejuyuu commented 3 weeks ago

@kmkurn Thanks! The commits are squashed into one.

kmkurn commented 3 weeks ago

Thank you for your contribution! The PR is now merged :-)