Rename kwargs to match PyTorch's convention

kmkurn / pytorch-crf

(Linear-chain) Conditional random field in PyTorch.

https://pytorch-crf.readthedocs.io

MIT License

938 stars 151 forks source link

Rename kwargs to match PyTorch's convention #2

Closed kmkurn closed 6 years ago

kmkurn commented 6 years ago

PyTorch uses reduce to indicate whether to sum/average loss in a batch. Right now we use summed. It's nice to rename this to reduce, but for backward compatibility maybe we can print a deprecation warning for now.