Closed kmnhan closed 2 weeks ago
In this approach, major changes to the loader may break existing code and saved data. It would be better to retain the current way of storing the data, and just add an accessor for convenience.
Things to consider:
What do we need in the accessor?
Are we OK with current attribute names? They may be confusing, i.e., temperature is temp_sample
but work function is sample_workfunction
...
Description
Currently, the data loader adds new keys to the data attributes to store common metadata like sample temperature.
For instance, if an endstation stores the sample temperature in the
"TB"
attribute, we would add a new key"temp_sample"
to the attributes and copy the value. This results in duplicate attributes with same value but different name, which can be confusing.Possible solution
We could try to preserve the original attributes.
The steps are:
Some expected problems with this approach:
Alternatives
No response
Additional context
No response