kmod-project / kmod

kmod - Linux kernel module handling
GNU Lesser General Public License v2.1
50 stars 39 forks source link

meson: don't escape module_foo in kmod.pc #217

Closed evelikov closed 3 weeks ago

evelikov commented 3 weeks ago

The kmod.pc file, contains module_signatures and module_compressions space-separated lists, indicating how kmod is built. For the meson generated file, any spaces are escaped where the autotools one does not do that.

Update the meson build to be consistent with the original autotools one and omit the escaping that we don't want.

Aside: seems like autotools does not escape the directory variables either, so if the path(s) have any spaces in them pkg-config (pkgconf at least) produces rubbish, quite rightfully IMHO.

Eg. $ cat .../autotools-file.pc prefix=/usr includedir=${prefix}/include bar Cflags: -I${includedir} ... $ pkg-config --cflags autotools-file.pc bar

$ cat .../meson-file.pc prefix=/usr includedir=${prefix}/include\ bar Cflags: -I${includedir} ... $ pkg-config --cflags meson-file.pc -I/usr/include\ bar

lucasdemarchi commented 3 weeks ago

Applied, thanks