search

kmoe / slack-pokebot

:dizzy: notify your coworkers when there are Pokémon nearby :dizzy:
MIT License
34 stars 7 forks source link

Adding ability to embed google maps image #26

Open jakeboyles opened 8 years ago

jakeboyles commented 8 years ago

Adds ability to embed google maps image.

jgthms commented 8 years ago

21 commits for changing 30 lines in 2 files? 😐

jakeboyles commented 8 years ago

Started off as just a personal project with other stuff built in then paired it down and decided to submit a pr. Was also testing a lot of heroku stuff that had to be pushed.

kmoe commented 8 years ago

@jakeboyles Please pull master and rebase (will give you a chance to fix the commits).

Can the Heroku instructions in the README be improved?

jakeboyles commented 8 years ago

Yep, Just wanted to see if there was an interest from you first. I'll update the readme with new instructions.

jakeboyles commented 8 years ago

Welp. It was cool while it lasted. They are blocking all heroku and Cloud based ips. The server will have to be run locally or on your own server.

http://www.forbes.com/sites/ryanmac/2016/07/31/pokemon-go-cuts-off-access-to-pokevision-and-other-creature-finding-apps/#1b54ccce3dba

kmoe commented 8 years ago

@jakeboyles do you have another source on that? Happy to run it on my own hardware but I want to be sure first as it's currently working fine.

jakeboyles commented 8 years ago

@kmoe Yeah, I am on the poke.io discord channel and a lot of people are seeing it on there. They may not have discovered the server that yours is running on yet. Just hearing they are rolling them out in batches. Have seen some people get banned as well. Just a warning that they are starting to not be as friendly. I figured it would come sooner than later.

jakeboyles commented 8 years ago

I re based and added in some better docs.

jakeboyles commented 8 years ago

Passing lint now.