search

kmonsoor / pyglet

Automatically exported from code.google.com/p/pyglet
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Sync pypng with upstream #668

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Upstream version contains more fixes that we've collected
   https://code.google.com/p/pyglet/source/list?path=/pyglet/image/codecs/pypng.py
   https://github.com/drj11/pypng/commits/master
2. It is better when fixes are merged (and tested) in upstream

What is the expected output? What do you see instead?

  from pyglet.exlibs import pypng

Original issue reported on code.google.com by techtonik@gmail.com on 27 Sep 2013 at 9:04

GoogleCodeExporter commented 9 years ago 
External modules should moved into pyglet.extlibs or better to pyglet.upstream 
(with README to encourage users to send patches there).

Original comment by techtonik@gmail.com on 29 Sep 2013 at 12:02

GoogleCodeExporter commented 9 years ago

Original comment by useboxnet on 30 May 2014 at 6:12

GoogleCodeExporter commented 9 years ago 
I have upstream png.py working on my copy.  what is this about pyglet.extlibs?

Original comment by Leif.The...@gmail.com on 21 Dec 2014 at 7:28

GoogleCodeExporter commented 9 years ago 
The pyglet.extlibs is just an idea to have separate package/directory for all 
upstream non-pyglet code.

Original comment by techtonik@gmail.com on 23 Dec 2014 at 1:31

GoogleCodeExporter commented 9 years ago

Original comment by Silveste...@gmail.com on 21 Jan 2015 at 6:55

GoogleCodeExporter commented 9 years ago 
Updated PyPNG to latest version. Fixes applied to original version have already 
been applied to this version.
Moved it to the extlibs package to clearly identify it as upstream code.

Original comment by Silveste...@gmail.com on 22 Jan 2015 at 7:04

GoogleCodeExporter commented 9 years ago 
I checked it using the image-png tests. Tested on both Py2 and Py3.

Original comment by Silveste...@gmail.com on 22 Jan 2015 at 7:05

GoogleCodeExporter commented 9 years ago 
Nice to know this is fixed, but I don't see where are the commits?

Moving completely to another package is now what I meant. The idea was to have 
pyglet.extlibs directly in repository so that it could be easily 
executable/importable right after the checkout without installing anything, 
messing virtualenvs etc.

Original comment by techtonik@gmail.com on 24 Jan 2015 at 2:03

GoogleCodeExporter commented 9 years ago 
The commits are on BitBucket. Starting at 
https://bitbucket.org/pyglet/pyglet/commits/716e1d795b6cb21b69a83babcbe52888eab1
5c77

Original comment by Silveste...@gmail.com on 24 Jan 2015 at 2:53

GoogleCodeExporter commented 9 years ago 
Opened issue about that - https://code.google.com/p/pyglet/issues/detail?id=768

Original comment by techtonik@gmail.com on 24 Jan 2015 at 4:59