search

kmoonki / oauth

Automatically exported from code.google.com/p/oauth
0 stars 0 forks source link

php: urlencode vs tilda #18

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Spec says ([1]) that tilda ('~') is unreserved character 
and MUST NOT be encoded. However php library escapes 
parameters using urlencode(), which converts tilda to '%7E'. 
Only in one place library fixes that. 

Attached patch introduces OAuthServer::paramEncode() method  
which does the job right. It replaces urlencode() everywhere in 
library. 

[1]: http://oauth.net/core/1.0/#encoding_parameters

Original issue reported on code.google.com by atregoub...@gmail.com on 26 Mar 2008 at 10:30

Attachments:

GoogleCodeExporter commented 9 years ago 
fixed some patches ago, thanks for the patch

Original comment by andyster on 15 Jul 2008 at 10:14