search

kmoonki / oauth

Automatically exported from code.google.com/p/oauth
0 stars 0 forks source link

Request parameters passed using the query part must be signed. #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

As per the discussion in this thread:
http://groups.google.com/group/oauth/browse_thread/thread/6ae9b3f6177683aa

The PHP OAuth library should sign request parameters in the URL query part.

I have attached the patch to this bug. Please let me know if you need any
additional clarifications regarding the bug or patch. 

Thank you,
Chirag Shah
Email: ChiragShah1@gmail.com

Original issue reported on code.google.com by chiragsh...@gmail.com on 2 Oct 2008 at 5:36

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by jmkrist...@gmail.com on 22 Oct 2008 at 5:25

GoogleCodeExporter commented 9 years ago 
I will discuss if the fix should infact be in the method you corrected it in, 
or in from_request, with Andy Smith, 
and then get this bug fixed..

-Morten

Original comment by morten.f...@gmail.com on 30 Jan 2009 at 6:25

GoogleCodeExporter commented 9 years ago 
Hey Fangel,

Were you able to check with Andy about this?

Thanks,
Chirag

Original comment by chiragsh...@gmail.com on 6 Feb 2009 at 7:08

GoogleCodeExporter commented 9 years ago 
Hi,

Sorry, I've been pretty busy trying to get all my previous patches reviewed, 
approved and commited so I haven't 
had time to do this yet (work and college takes time too). I will as soon as I 
get time..

-M

Original comment by morten.f...@gmail.com on 6 Feb 2009 at 7:12

GoogleCodeExporter commented 9 years ago 
Chirag, I believe this is fixed, but could you confirm?

Original comment by morten.f...@gmail.com on 18 May 2009 at 6:00

GoogleCodeExporter commented 9 years ago 
Sorry, I forgot what this was about, but after reviewing your patch again, I 
can see it's not yet fixed... 

The issue will be if you use OAuthRequest::from_consumer_and_token, and pass in 
a url with query parameters..

Original comment by morten.f...@gmail.com on 21 May 2009 at 11:54

GoogleCodeExporter commented 9 years ago 
I want this fixed too. Passing query params extracted using 
OAuthRequest::from_consumer_and_token isn't 
quite efficient. +1 on Chirag's patch.

Original comment by agek...@gmail.com on 24 Dec 2009 at 5:37

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r1163.

Original comment by morten.f...@gmail.com on 5 Jan 2010 at 11:24