kmorales13 / SleepPunisher

SleepPunisher Mod for Fabric 1.16.5
Mozilla Public License 2.0
0 stars 0 forks source link

Use block tags to define blocks eligible for `stoveFire` #3

Open James103 opened 3 years ago

James103 commented 3 years ago

https://github.com/kmorales13/SleepPunisher/blob/ffd9e58a55391e9b0ecfb29e58736ed7d7031c46/src/main/java/net/sleeppunisher/SleepPunisher.java#L229-L230

Currently, as shown above, the blocks eligible for stoveFire are hardcoded into the mod. Since the general direction is that Minecraft wants to become more data-driven, I think the eligible blocks should be moved into its own separate tag which is searched for instead when determining whether stoveFire executes successfully. Datapacks could then change this to their liking, for example by also allowing campfires and lava to count towards stoveFire.

Name of tag (subject to change): sleeppunisher:stove_fire_sources Default contents:

minecraft:furnace
minecraft:blast_furnace
minecraft:smoker