search

kmoskwiak / videojs-resolution-switcher

Resolution switcher adds the ability to select the video quality in video.js player.
https://kmoskwiak.github.io/videojs-resolution-switcher/
Other
402 stars 244 forks source link

Is this plugin abandoned? #102

Closed emmgfx closed 3 years ago

emmgfx commented 6 years ago

Last commit is from more than a year ago, and actually seems that doesn't work well on the latest versions of videojs. Is this plugin abandoned?

Gataquadrada commented 6 years ago

As mentioned here, this plugin only works with Video.JS 5. So, yeah, I'd consider that as "abandoned".

EDIT: I know. Iknow. Almost a year after the original question. But people may come here searching for answers.

npstcole commented 5 years ago

Does anyone know of a branch for using with videoJS version 6+?

Gataquadrada commented 5 years ago

@npstcole I went with a custom solution. I added a custom button and used jQuery to show a custom popup that changes the src based on what quality the user chooses.

You can see the result here.

EDIT: Changing the src will trigger every event set to fire on video load.

npstcole commented 5 years ago

Thanks, I use something very similar for AD videos using a custom button as well. The problem I'm going to run into is that we now need to add playlists to this and I'm looking for a way to modify the existing code to work since playlists don't seem to support multiple resolutions out of the box. This has me hunting down a rabbit hole of upgrading from 5.x to 6+ researching possibilities for off the shelf solutions. We have A LOT going on as you can see here

Gataquadrada commented 5 years ago

Well, the best way to overcome something is to go through it. I updated from 5.x to 6.x and have no regrets. A lot of stuff is just plain easier than before. Adding a button (solving my case, in general) was a matter of 5 lines of code, with 6.x.