search

kmpoppe / fhrsPlugin

JOSM Plugin: Search establishments in FHRS API and merge data into OSM
https://wiki.openstreetmap.org/wiki/User:Kmpoppe/Plugins#fhrsPlugin
GNU General Public License v3.0
4 stars 0 forks source link

Unable To Search By Name #8

Closed pqhf5kd closed 4 years ago

pqhf5kd commented 4 years ago

The menu "Search entry" looks up establishments in FHRS using this three options in order:

name and address address only name only

image

Is searching by name disabled while you work on #4 ?

If #7 can be fixed and we're able to search by name, this plugin would even more useful allowing us to population address and FHRS info at once.

Thanks :)

kmpoppe commented 4 years ago

No, searching by name isn't disabled per se, there's just something wrong in my logic to allow searching without an address... Will need to figure out what went wrong. Which node/way did you select to reach this message?

pqhf5kd commented 4 years ago

Here are two examples:

kmpoppe commented 4 years ago

I changed the logic to be name & address OR address. Name only will not work consistently, so this is not an option for the time being ;-) ... And of course the plugin now asks for an address if there's none in the object.

kmpoppe commented 4 years ago

When using the Node 6691214599 and entering "station road new milton" when prompted, you get this result to merge: image I guess this now works as intended :-D Will publish 0.1.5 in a few minutes for you. BTW: I can't find Dukes Station Cafe, I guess it has a new name now?

pqhf5kd commented 4 years ago

This works great but is it possible to cache the last entry in the 'Input' window? That way a user can go along a street or through a whole town without having to type, or paste, the input.

pqhf5kd commented 4 years ago

@kmpoppe I thought that commenting would reopen this but I guess not?