kmrshntr / omniauth-slack

omniauth-slack
MIT License
95 stars 156 forks source link

Please update the rubygems.org version to the latest version. #52

Open zanloy opened 7 years ago

zanloy commented 7 years ago

I spent quite a while trying to figure out why my response was coming back nil before I realized the version on rubygems.org is like a year old. As soon as I pointed it to this repository, it worked great. This might help a lot more people in the future who don't want to add a bunch of github repos directory in their Gemfile.

JustLey commented 7 years ago

@zanloy I recent went through the issues/PRs on this repo and read somewhere that @kmrshntr will be dealing with this gems issues and release in the next weeks when he has some free time. Can't remember where, but I guess we'll have to wait. I advise you to use :github => 'kmrshntr/omniauth-slack', :ref => 'commit_number' if you need some updated code (I personally use this commit

Edit: I don't reccomend using it if you use other authentication providers because it's on version 1.3.1 of omniauth-oauth2 (I use it because I had some errors when I updated to the latest commit and Slack is my only provider)

mauriciosouto commented 7 years ago

Hi @zanloy

Can you share your gemfile? or any other tip. I'm trying to use this repo (can't get user email with rubygem repo) and the only thing I can get is Could not authenticate you from Slack because "Invalid credentials".

Thanks

zanloy commented 7 years ago

@mauriciosouto I actually forked this repo because I couldn't wait for the PR to fix a common error. But here is the line in my Gemfile:

gem 'omniauth-slack', git: 'https://github.com/zanloy/omniauth-slack.git'

mauriciosouto commented 7 years ago

Thanks @zanloy I got the email working with your fork...

adrianotadao commented 7 years ago

I think the better is to have a new version of the gem. If we use the master, we can have problems =(

@kmrshntr could you please generate a new version? 💟

dkniffin commented 7 years ago

I'd also like to see the rubygems version get bumped. @kmrshntr: it looks like you're not very active on github anymore. I don't know much about omniauth, but I have managed some ruby gems in the past. I'd be happy to help maintain this one, if you're interested.

adrianotadao commented 7 years ago

I can help too @dkniffin ... I have a fork here but I world like to use the rubygem version

kevinelliott commented 7 years ago

What is going on with this?

alfredvaa commented 6 years ago

I got nil as uid in the response when using this gem. Turns out I had to add the github reference in my Gemfile to make it work: gem 'omniauth-slack', github: 'kmrshntr/omniauth-slack'

It would be nice if a new version of the gem is released with the latest stuff.

dkniffin commented 6 years ago

Judging from @kmrshntr's activity, we might be looking at abandonware here...

alfredvaa commented 6 years ago

@dkniffin Yes, it looks like that. I really just wanted to leave the solution here if anyone else was wondering.