Closed sbchisholm closed 8 years ago
Looks really good--thanks!
Thanks for the feedback. It's also worth noting this only adds support for logging to syslog via UDP. Syslog also supports logging to a local socket and over TCP (something to look into adding in the future).
@kmsquire I recently updated this PR, fixed a few julia 0.4 deprecation warnings and added a max message length attribute to the SysLog type, this allows you to truncate log messages. I was finding that my application was crashing on some large debug messages when trying to send them over the UDPSocket
.
@kmsquire Any plans to merge this in?
We're going to be keeping a fork at https://github.com/analyzere/Logging.jl so I have a vested interest in preventing these two from diverging too much :)
Thanks for the bump. I've been working my way through issues in other packages, and haven't spent a lot of love here.
No problem, I've seen the other things you've been doing, you're very busy. Thanks!
@sbchisholm @DanielArndt I've added you both as collaborators here, so if there other things that you see that need attention, I'd love the help.
My hopes/plans:
It seems that people use this package, so I think the first item is reasonable so that at least more people have access to fix things. That said, just moving it to JuliaLang doesn't guarantee that.
For the others, I don't know if/when I will find the time. Like a lot of people, I'm a volunteer here, and my availability ebbs and flows. I'm also about to become a first-time father, so I should probably take care of at least the first item pretty soon... ;-)
"INFO"
or"DEBUG"
etc.).