search

kmsquire / Logging.jl

Logging package for julia
Other
43 stars 26 forks source link

Fix warnings on v0.4.0-rc2: rename String -> AbstractString #23

Closed r9y9 closed 8 years ago

r9y9 commented 9 years ago

String is deprecated in v0.4.

It works both on Julia v0.3 and v0.4 thanks to Compat.jl.

r9y9 commented 9 years ago

It seems that there is a problem on nightly, though I think it's unrelated to this change.

maximsch2 commented 8 years ago

@kmsquire, any plans to merge this? This is a useful and benign change.

kmsquire commented 8 years ago

Thanks for the ping, and sorry I hadn't updated earlier. I had wanted to fix the error (and still do), but it had fallen off of my radar.