Fix Logger constructor - Githubissues

kmsquire / Logging.jl

Logging package for julia

Other

43 stars 26 forks source link

Fix Logger constructor #32

Closed DanielArndt closed 8 years ago

DanielArndt commented 8 years ago

Related to #31

Fixed issue with LogOutput arrays of the same type (ie. [STDOUT,STDERR])
Added test_hierarchy tests to the suite

I'm not sure that the test_hierarchy tests are the most honest way of testing these constructors are working. Although they do provide some valuable testing, it seems like it is actually hiding what we intended to test. Any thoughts?

kmsquire commented 8 years ago

test_hierarchy could probably be fleshed out more... maybe open an issue?

For now, this looks good to me. Feel free to merge if you're happy with it.