search

kmsquire / Logging.jl

Logging package for julia
Other
43 stars 26 forks source link

Attempt to fix Julia v0.6 support #54

Closed rdeits closed 7 years ago

rdeits commented 7 years ago

There were some changes to the way keyword arguments are parsed in Julia v0.6 that broke Logging.jl. I believe this should fix it, but I'd appreciate it if someone familiar with how the package works could try it as well (the unit tests are passing, but I don't know the expected behavior well).

kmsquire commented 7 years ago

I think this is a step in the right direction, but I probably can't release a version yet. Julia has moved more strongly to the convention that packages should not overwrite Base functions, so the fact that we (intentionally) overwrite Base.info and Base.warn probably isn't going to fly.

I'll try to commit some time to address this issue over the weekend.

(You also might consider using Memento.jl, which seems not to have this issue and looks to be quite well written.)

Cheers!

rdeits commented 7 years ago

Ok, thanks! Memento.jl does look quite nice, and I've been looking at the new logging features in Base too. But my goal here was just to un-break Mocha.jl :)