search

kmtong / logback-redis-appender

Logback Redis Appender
Apache License 2.0
114 stars 64 forks source link

Not compatible with jedis-3.1.0 #23

Open bwrega opened 4 years ago

bwrega commented 4 years ago

com.cwbase.logback.RedisAppender calls methods redis.clients.jedis.JedisPool.returnBrokenResource(...) and redis.clients.jedis.JedisPool.returnResource(...) that are marked as protected in jedis-3.1.0 (and my guess is that it's disabled since jedis-3.0.0).

redis.clients.jedis.Jedis.close() should be called instead

derkoe commented 4 years ago

Seems like this is fixed with #22

drapej commented 4 years ago

Yes, i think too, but the version 1.1.6 is not released and not in the maven central repo.