search

kmukku / php-iso11649

ISO 11649 creditor reference library for php
11 stars 5 forks source link

PHPUnit dependency requires PHP >= 7.3 #5

Open sadamczyk-eos opened 3 years ago

sadamczyk-eos commented 3 years ago

Hi,

the composer.json states that this package only requires PHP >=5.4.0, but the phpunit ^9.1 dependency that was added in the last PR requires PHP >=7.3.

    "require": {
        "php": ">=5.4.0",
        "phpunit/phpunit": "^9.1"
    }

One option would be to downgrade to phpunit version ^4.8, since this only requires php >=5.3.3. I would probably suggest this, since the unit tests in this package are quite simple, and it would allow people with lower PHP versions to still use this package. This might break the tests though, so I'm not sure. 😄

Option 2 would be to just require the higher PHP version.

In either case the phpunit dependency should probably be moved to require-dev instead of require, right?