search

kmukku / php-iso11649

ISO 11649 creditor reference library for php
11 stars 5 forks source link

Move phpunit to require-dev #8

Closed EdwardCaulfield closed 1 year ago

EdwardCaulfield commented 1 year ago

Our team prefers not to have phpunit in production code.

sadamczyk-eos commented 1 year ago

@EdwardCaulfield I suggested this change in the last sentence of https://github.com/kmukku/php-iso11649/issues/5, so thanks for making a PR for this! :) Would you be able to test if a downgrade of phpunit to version ^4.8 breaks the current tests? Because then that whole issue could be resolved as well.

EdwardCaulfield commented 1 year ago

Would you be able to test if a downgrade of phpunit to version ^4.8 breaks the current tests?

No, I am not in a position to do that.

kmukku commented 1 year ago

Seems legit. If you guys want to collaborate with this repo, I'm happy to add. I have no use for this myself anymore and haven't use PHP for a while.