search

knadh / dns.toys

A DNS server that offers useful utilities and services over the DNS protocol. Weather, world time, unit conversion etc.
https://www.dns.toys
MIT License
2.48k stars 135 forks source link

feat: get stock prices #61

Closed suraj-ranganath closed 1 year ago

suraj-ranganath commented 1 year ago

Right now, we only get US stock prices but I will create an issue so that the community could work on getting Indian stock prices as well.

knadh commented 1 year ago

Thanks for the PR @suraj-ranganath. Stock prices are a bit tricky. The current implementation fetches a webpage for every query which is not scalable. It has to work like weather, fetch and cache for a certain period. But then again, are cached/stale stock prices useful?

suraj-ranganath commented 1 year ago

Thank you for the review @knadh. That's fair. I've tried work arounds but seem to have hit a brick wall. I have another feature in mind, will work on that.