knadh / listmonk

High performance, self-hosted, newsletter and mailing list manager with a modern dashboard. Single binary app.
https://listmonk.app
GNU Affero General Public License v3.0
14.73k stars 1.35k forks source link

Campaign editor images "expired" when returning to a draft #1872

Open kontur opened 4 months ago

kontur commented 4 months ago

Version:

Description of the bug and steps to reproduce: When returning to a campaign draft previously added images appear blank in the editor. When inspecting with right-click and revealing the image URL I get an expired resource. In the media view I can see the same image still present and inspecting it from there the link opens just fine.

Screenshots: The image in the media gallery where it shows just fine:

Screenshot 2024-05-28 at 11 20 46

The editor view of the campaign draft missing the images:

Screenshot 2024-05-28 at 11 21 08

The editor view image detail of the missing image:

Screenshot 2024-05-28 at 11 20 56
knadh commented 4 months ago

Could you please share a screenshot of your S3 settings (Settings -> Media)?

kontur commented 4 months ago
Screenshot 2024-05-28 at 14 41 33

Does the greyed out 14d mean that is the default? And if so, why are those still showing in the Media browser then?

knadh commented 4 months ago

That's a placeholder on the empty field. Can you try entering a value like "14d" and see if the issue persists?

kontur commented 4 months ago

Just adding the 14d, saving, and viewing the existing campaign draft again the result is the same.

(Optional) Specify expiry for the generated presigned URL. Only applicable for private buckets (s, m, h, d for seconds, minutes, hours, days).

knadh commented 4 months ago

These are S3 specific parameters (Signed URLs) for private buckets, where the files are private and publicly accessible only for a certain period of time. No value there implies no expiry, so I'm unsure what's causing this behaviour. Setting a value there and testing would help. Media gallery vs campaign editor, again, I'm unsure. Need to investigate this.

kontur commented 4 months ago

Okay, roger that. Thanks for looking into it. The initial expiry value in the settings definitely was unset, so it would use whatever it defaults to. Let me know if there is something I can test in the meantime.

Also, what does this expiry mean for assets once a newsletter gets sent? Will they also expire e.g. after 2 weeks when recipients open their emails?

github-actions[bot] commented 1 month ago

This issue has been marked 'stale' after 90 days of inactivity. If there is no further activity, it will be closed in 7 days.

kontur commented 1 month ago

This is still unclear in the UI.