search

knadh / localStorageDB

A simple database layer for localStorage and sessionStorage for creating structured data in the form of databases and tables
http://nadh.in/code/localstoragedb
814 stars 128 forks source link

Missing comma on line 372 #23

Closed objectivehtml closed 10 years ago

objectivehtml commented 10 years ago

Don't have time to make a proper pull request. Just FYI, this lib is great. I use it a lot and taught it to my students in a mobile application class at a college I worked last year.

Anyway... on line 372 on the unminified version is missing a comma. Also, do you have a changelog of what has changed in 2.1?

patik commented 10 years ago

@objectivehtml It's incredibly quick and easy to make pull requests for things like this right in the browser. Just go to the file, click the Edit button at the top, and the file will open in a web-based text editor. Make the change and click the big green "Propose file change" button at the bottom and it will create a pull request automatically. (This wouldn't be a bad thing to show your students if you cover git at all.)

objectivehtml commented 10 years ago

I forgot I could do that. I just did it.

I am not teaching anymore so I can't show them this unfortunately. I did cover git extensively though. ;)