knaeckeKami / diffutil.dart

Apache License 2.0
29 stars 4 forks source link

fix endless loop when re-offsetting postponed updates #19

Closed knaeckeKami closed 11 months ago

knaeckeKami commented 1 year ago

fixes #18 by aligning it with https://android.googlesource.com/platform/frameworks/support/+/refs/heads/androidx-main/recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/DiffUtil.java?source=post_page---------------------------%2F&autodive=0%2F#971

codecov[bot] commented 1 year ago

Codecov Report

Merging #19 (21cb591) into master (f757e8f) will decrease coverage by 0.22%. The diff coverage is 50.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/knaeckeKami/diffutil.dart/pull/19/graphs/tree.svg?width=650&height=150&src=pr&token=APNSED5LDL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Kamleithner)](https://app.codecov.io/gh/knaeckeKami/diffutil.dart/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Kamleithner) ```diff @@ Coverage Diff @@ ## master #19 +/- ## ========================================== - Coverage 97.21% 96.99% -0.22% ========================================== Files 4 4 Lines 431 433 +2 ========================================== + Hits 419 420 +1 - Misses 12 13 +1 ``` | [Files](https://app.codecov.io/gh/knaeckeKami/diffutil.dart/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Kamleithner) | Coverage Δ | | |---|---|---| | [lib/src/diffutil\_impl.dart](https://app.codecov.io/gh/knaeckeKami/diffutil.dart/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Kamleithner#diff-bGliL3NyYy9kaWZmdXRpbF9pbXBsLmRhcnQ=) | `96.39% <50.00%> (-0.31%)` | :arrow_down: |