search

knah / VRCMods

A collection of various VRChat mods aimed at improving user experience or fixing issues
GNU General Public License v3.0
245 stars 137 forks source link

UIX: Fix visible CameraExpando in Camera rendering #189

Closed dakyneko closed 2 years ago

dakyneko commented 2 years ago

The CameraExpando was visible in the Camera. The Content object had the layer "Water" which is not correct, I put UI here. Also I used the LayerMask so it's future proof. In fact it's totally possible this bug is the result of VRC changing layer id.

Not sure if "UI" is the one we want here but it works in game.

dakyneko commented 2 years ago

In my experiment I didn't see any effect but this line is also very suspicious:

https://github.com/knah/VRCMods/blob/master/UIExpansionKit/UiExpansionKitMod.cs#L375

            SetLayerRecursively(expando, 4);

should we patch it too? I doubt we want layer Water 4 here?

dakyneko commented 2 years ago

Actually using layer "UI" prevents from using the camera menu without opening the quick menu. Not really great. Will check better idea later.

PS: ViewFinder UI is using layer "InternalUI" may try that.

knah commented 2 years ago

I've fixed this during remake of camera expando - UIX panel now uses same layer as other camera UI.