search

knalli / homebridge-pilight

Accessory plugin for Homebridge allowing to manage and control pilight devices
MIT License
16 stars 3 forks source link

Better Logging #2

Closed rabenhorst closed 8 years ago

rabenhorst commented 8 years ago

I needed better logging because I had some problems with pilight. Maybe you could merge my changes into your code.

knalli commented 8 years ago

@mactr0n Thank you. Wow, the hound cracked up. :(

I've just removed the comments, I'll investigate that later.

Anyway: The intention of this.id instead of the general Websocket in log messages is the plugin will be initiated multiple times (that's why this comment (still) exists. Also just now I'm not sure anymore why I've chosen a map this.deviceStates instead of this.deviceState.

knalli commented 8 years ago

@mactr0n Ironically, neither the hound or the test have found a more serious issue.. your index.js has severe code duplication issue.. perhaps a local merge failed?

rabenhorst commented 8 years ago

Really strange. I don’t know what happened. Let me just fix it.

Von: Jan Philipp notifications@github.com<mailto:notifications@github.com> Antworten an: knalli/homebridge-pilight reply@reply.github.com<mailto:reply@reply.github.com> Datum: Donnerstag, 4. Februar 2016 um 22:56 An: knalli/homebridge-pilight homebridge-pilight@noreply.github.com<mailto:homebridge-pilight@noreply.github.com> Cc: mactron sebastian.rabenhorst@rwth-aachen.de<mailto:sebastian.rabenhorst@rwth-aachen.de> Betreff: Re: [homebridge-pilight] Better Logging (#2) Neu gesendet von: sebastian.rabenhorst@rwth-aachen.de<mailto:sebastian.rabenhorst@rwth-aachen.de>

@mactr0nhttps://github.com/mactr0n Ironically, neither the hound or the test have found a more serious issue.. your index.js has severe code duplication issue.. perhaps a local merge failed?

— Reply to this email directly or view it on GitHubhttps://github.com/knalli/homebridge-pilight/pull/2#issuecomment-180069144.

rabenhorst commented 8 years ago

It should be fixed now. Should I change the connecting message back to this.id?

knalli commented 8 years ago

Well, I've to look at it. If it does not match, I will skip the specific lines.

knalli commented 8 years ago

Please squash your commits and rebase the new one onto the master. I've applied a configuration for the hound, should not bark so much again.

rabenhorst commented 8 years ago

Ok im busy right now and will do the squash in renaming tomorrow

rabenhorst commented 8 years ago

I squashed the commits and renamed lightbulbService to switchService.

knalli commented 8 years ago

Landed as e0166ff and 04ab067. I had to extract the commit for better diff changes, but put the credits in the text.

@mactr0n Thank you for the work.

Note: I've left the changes with the connection, this is much more better for reading.

knalli commented 8 years ago

Go for 1.1.0