search

knapsu / plex-media-player-flatpak

Linux Flatpak packages for Plex Media Player application.
https://knapsu.eu/plex/
GNU General Public License v3.0
14 stars 2 forks source link

upgrade framework, sdk and dependencies to newer versions #13

Closed syco closed 2 years ago

syco commented 2 years ago

kde framework 5.9 is long deprecated and can be replaced with 5.15 + "io.qt.qtwebengine.BaseApp". While testing I also upgraded a bunch of other dependencies.

knapsu commented 2 years ago

@syco your changes looks solid! Was not aware that Flatpak has a base field that can be used this way. Nice. Will fix the CI and approve your pull request immediately after. Thank you very much for your work.

syco commented 2 years ago

I pushed a new commit for my repo, didn't know it would have updated this push request.

Anyway, here's what changed: MPV is now compiled in a dedicated module in the modules folder.

MPV is very powerful and has a lot of optional dependencies, but most of them where not included in this plex build, I think the screen tear and the lag I was having are related to these dependencies.

So, I took the MPV manifest from https://github.com/flathub/io.mpv.Mpv and made it into a module, this way we don't have to deal with the headache of figuring out all the dependencies. If you diff https://github.com/syco/plex-media-player-flatpak/blob/master/modules/io.mpv.Mpv.yml and https://github.com/flathub/io.mpv.Mpv/blob/master/io.mpv.Mpv.yml you can see how easily this can be done.

Let me know what you think. Thanks.

knapsu commented 2 years ago

Building cmake is indeed no more needed with latest Flatpak KDE SDK. The HTTPS issue is no longer there.

Moving MPV into a module looks magnificent. But what is more, having a fine tuned build configuration options for it (and FFmpeg) is something even greater. Love your work :heart:

CI is now done on GitHub. I've prepared new Docker build images to handle Flatpak Qt 5.15 dependencies and your changes.

Once again, thanks @syco for all the great work you had done. Merging.