search

knative-extensions / autoscaler-keda

Keda based Knative HPA Autoscaler
Apache License 2.0
2 stars 5 forks source link

Run Serving HPA e2e tests #17

Closed skonto closed 5 months ago

skonto commented 5 months ago

Changes

--- PASS: TestHPAAutoscaleUpDownUp (440.41s) PASS ok knative.dev/serving/test/e2e 440.429s

On Minikube requires it minikube addons enable metrics-server for CPU, MEM to work with HPA.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 53.60%. Comparing base (3d7c59a) to head (4d46871). Report is 2 commits behind head on main.

Files Patch % Lines
pkg/reconciler/autoscaling/hpa/resources/keda.go 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #17 +/- ## ========================================== - Coverage 54.58% 53.60% -0.99% ========================================== Files 5 5 Lines 218 222 +4 ========================================== Hits 119 119 - Misses 91 95 +4 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skonto commented 5 months ago

Tests pass

skonto commented 5 months ago

Need to fix TestHPAAutoscaleUpDownUpMem at the Serving side as it has been disabled for a long time: https://github.com/knative/serving/issues/11944. I will enable it here and see.

skonto commented 5 months ago

/assign @ReToCode /assign @dsimansk

dsimansk commented 5 months ago

/approve /lgtm

knative-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/autoscaler-keda/blob/main/OWNERS)~~ [dsimansk,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment