knative-extensions / autoscaler-keda

Keda based Knative HPA Autoscaler
Apache License 2.0
2 stars 5 forks source link

Add e2e test for custom metrics #26

Closed skonto closed 4 months ago

skonto commented 4 months ago

Changes

Fixes #12

Release Note

Custom metrics are now tested e2e.  
knative-prow[bot] commented 4 months ago

@skonto: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/autoscaler-keda/pull/26): > > > > ># Changes > > > >- TBD >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.63%. Comparing base (5c704df) to head (2f0dcc5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #26 +/- ## =========================================== + Coverage 53.60% 63.63% +10.03% =========================================== Files 5 4 -1 Lines 222 187 -35 =========================================== Hits 119 119 + Misses 95 60 -35 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/autoscaler-keda/blob/main/OWNERS)~~ [ReToCode,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment