knative-extensions / autoscaler-keda

Keda based Knative HPA Autoscaler
Apache License 2.0
2 stars 4 forks source link

Adds support for KEDA auth #29

Closed skonto closed 3 months ago

skonto commented 3 months ago

Changes

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 87.31343% with 17 lines in your changes missing coverage. Please review.

Project coverage is 84.10%. Comparing base (752e522) to head (22368a9). Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
...onciler/autoscaling/hpa/resources/scaled_object.go 90.62% 6 Missing :warning:
pkg/reconciler/autoscaling/hpa/helpers/helpers.go 87.09% 2 Missing and 2 partials :warning:
pkg/reconciler/autoscaling/hpa/resources/keda.go 88.57% 2 Missing and 2 partials :warning:
pkg/reconciler/autoscaling/hpa/keda_hpa.go 33.33% 1 Missing and 1 partial :warning:
...conciler/autoscaling/hpa/config/autoscaler_keda.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## =========================================== + Coverage 66.07% 84.10% +18.02% =========================================== Files 6 8 +2 Lines 227 346 +119 =========================================== + Hits 150 291 +141 + Misses 66 39 -27 - Partials 11 16 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/autoscaler-keda/blob/main/OWNERS)~~ [ReToCode,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment