search

knative-extensions / autoscaler-keda

Keda based Knative HPA Autoscaler
Apache License 2.0
2 stars 4 forks source link

BYO scaledobject #31

Closed skonto closed 3 months ago

skonto commented 3 months ago

Changes

/kind

Fixes #13

Release Note

BYO scaledobject is now supported and can be configured per service.
knative-prow[bot] commented 3 months ago

@skonto: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/autoscaler-keda/pull/31): > > > > ># Changes > > > >- Allow user to define their own scaled object. This can be done per service or globally. >- TODO: add an example to doc files > > >/kind > > >Fixes #13 > > > >**Release Note** > > >```release-note >BYO scaledobject is now supported and can be configured per service. >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 51.21951% with 20 lines in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (71dad4a) to head (4ed5c93). Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/autoscaling/hpa/keda_hpa.go 39.39% 13 Missing and 7 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #31 +/- ## ========================================== - Coverage 84.10% 83.28% -0.82% ========================================== Files 8 8 Lines 346 359 +13 ========================================== + Hits 291 299 +8 - Misses 39 43 +4 - Partials 16 17 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skonto commented 3 months ago

@ReToCode I think this is ready.

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/autoscaler-keda/blob/main/OWNERS)~~ [ReToCode,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment