search

knative-extensions / autoscaler-keda

Keda based Knative HPA Autoscaler
Apache License 2.0
2 stars 4 forks source link

Allow more options #35

Closed skonto closed 3 months ago

skonto commented 3 months ago

Changes

Fixes #20 Fixes #32 Fixes #33

Release Note

Add support for extra Prometheus triggers and scaled modifiers. Allow to pass a scaled object directly via annotations in auto-create (managed mode).
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 62.94643% with 83 lines in your changes missing coverage. Please review.

Project coverage is 73.46%. Comparing base (3691e64) to head (e851413). Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/autoscaling/hpa/helpers/helpers.go 33.33% 40 Missing and 2 partials :warning:
pkg/reconciler/autoscaling/hpa/resources/keda.go 77.50% 20 Missing and 7 partials :warning:
...onciler/autoscaling/hpa/resources/scaled_object.go 63.15% 8 Missing and 6 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== - Coverage 83.28% 73.46% -9.83% ========================================== Files 8 8 Lines 359 520 +161 ========================================== + Hits 299 382 +83 - Misses 43 108 +65 - Partials 17 30 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skonto commented 3 months ago

/hold testing scale to zero

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/autoscaler-keda/blob/main/OWNERS)~~ [ReToCode,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
skonto commented 3 months ago

/unhold