Closed knative-automation closed 2 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: knative-automation, ReToCode
The full list of commands accepted by this bot can be found here.
The pull request process is described here
New changes are detected. LGTM label has been removed.
@knative-automation: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
unit-tests_autoscaler-keda_main | 0ad4770b4ad4a565ddcf698e9b6d229b71a20de7 | link | true | /test unit-tests |
build-tests_autoscaler-keda_main | 0ad4770b4ad4a565ddcf698e9b6d229b71a20de7 | link | true | /test build-tests |
integration-tests_autoscaler-keda_main | 0ad4770b4ad4a565ddcf698e9b6d229b71a20de7 | link | true | /test integration-tests |
vendor/sigs.k8s.io/controller-runtime/pkg/metrics/leaderelection.go:26:71: undefined: leaderelection.SwitchMetric
This is a known issue, the leaderelection API changed in 1.30: https://github.com/kubernetes/kubernetes/pull/122069. I will try upgrade the controller runtime dependency to a newer one (the controller runtime indirect dep comes from keda core so I will update that).
PR needs rebase.
Cron -knative-prow-robot
/cc knative-extensions/autoscaler-keda-approvers /assign knative-extensions/autoscaler-keda-approvers
Produced by: knative-extensions/knobots/actions/update-deps