search

knative-extensions / autoscaler-keda

Keda based Knative HPA Autoscaler
Apache License 2.0
2 stars 5 forks source link

[main] Upgrade to latest dependencies #42

Closed knative-automation closed 2 months ago

knative-automation commented 3 months ago

Cron -knative-prow-robot

/cc knative-extensions/autoscaler-keda-approvers /assign knative-extensions/autoscaler-keda-approvers

Produced by: knative-extensions/knobots/actions/update-deps

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/autoscaler-keda/blob/main/OWNERS)~~ [ReToCode] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow[bot] commented 3 months ago

New changes are detected. LGTM label has been removed.

knative-prow[bot] commented 3 months ago

@knative-automation: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_autoscaler-keda_main 0ad4770b4ad4a565ddcf698e9b6d229b71a20de7 link true /test unit-tests
build-tests_autoscaler-keda_main 0ad4770b4ad4a565ddcf698e9b6d229b71a20de7 link true /test build-tests
integration-tests_autoscaler-keda_main 0ad4770b4ad4a565ddcf698e9b6d229b71a20de7 link true /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
skonto commented 3 months ago 
vendor/sigs.k8s.io/controller-runtime/pkg/metrics/leaderelection.go:26:71: undefined: leaderelection.SwitchMetric

This is a known issue, the leaderelection API changed in 1.30: https://github.com/kubernetes/kubernetes/pull/122069. I will try upgrade the controller runtime dependency to a newer one (the controller runtime indirect dep comes from keda core so I will update that).

knative-prow-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.