knative-extensions / autoscaler-keda

Keda based Knative HPA Autoscaler
Apache License 2.0
2 stars 4 forks source link

Debug codegen #45

Closed skonto closed 2 months ago

skonto commented 2 months ago

Changes

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.46%. Comparing base (631bd0c) to head (80343b4). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## ======================================= Coverage 73.46% 73.46% ======================================= Files 8 8 Lines 520 520 ======================================= Hits 382 382 Misses 108 108 Partials 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dsimansk commented 2 months ago

/approve /lgtm

knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/autoscaler-keda/blob/main/OWNERS)~~ [dsimansk,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
skonto commented 2 months ago

/test ?

knative-prow[bot] commented 2 months ago

@skonto: The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/knative-extensions/autoscaler-keda/pull/45#issuecomment-2328300526): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
skonto commented 2 months ago

/override integration-tests

knative-prow[bot] commented 2 months ago

@skonto: skonto unauthorized: /override is restricted to Repo administrators.

In response to [this](https://github.com/knative-extensions/autoscaler-keda/pull/45#issuecomment-2328301099): >/override integration-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dsimansk commented 2 months ago

/override integration-tests

knative-prow[bot] commented 2 months ago

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/knative-extensions/autoscaler-keda/pull/45#issuecomment-2328309582): >/override integration-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dsimansk commented 2 months ago

/override integration-tests_autoscaler-keda_main

knative-prow[bot] commented 2 months ago

@dsimansk: Overrode contexts on behalf of dsimansk: integration-tests_autoscaler-keda_main

In response to [this](https://github.com/knative-extensions/autoscaler-keda/pull/45#issuecomment-2328310828): >/override integration-tests_autoscaler-keda_main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.