Open muscionig opened 6 days ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: muscionig Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @muscionig. Thanks for your PR.
I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
I will open another issue for documenting Openshift ServiceMesh.
closes #56
Changes
This PR adds documentation to run the
autoscaler-keda
extension withIstio
injection. @skonto I opened this on top of #81, that is why the set of changes is larger. Feel free to directly review only this PR.Minor Changes
Istio
.istio
in mesh mode.prometheus
in its own namespace (to facilitate mTLS setup with the documentation provided byIstio
) and edits to theconfig-autoscaler-keda
configmap to scrape metric from a specific prometheus address.istio
:before scaling:
During scaling:
/kind documentation /kind enhancement