Closed aliok closed 1 month ago
@pierDipi Code generation verification is not done in Prow jobs in other repos, right? Similarly, code generation verification is not done during a release in other repos?
Code generation verification is not done in Prow jobs in other repos, right?
Yes, that part is based on the existence of the hack/verify-codegen.sh
file (which is not present in this repo), https://github.com/knative/hack?tab=readme-ov-file#using-the-presubmit-testssh-helper-script, point 2
Similarly, code generation verification is not done during a release in other repos?
no, it is done, this runs in the build tests job and those run before the release
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aliok, pierDipi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/override "Code Style / style / Golang / Lint"
@aliok: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:
Code Style / style / Golang / Lint
Only the following failed contexts/checkruns were expected:
EasyCLA
build-tests_backstage-plugins_main
e2e-tests_backstage-plugins_main
style / Golang / Lint
style / suggester / github_actions
tide
unit-tests_backstage-plugins_main
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.
/override "style / Golang / Lint"
@aliok: Overrode contexts on behalf of aliok: style / Golang / Lint
TODO:
func
version): https://github.com/knative/release/pull/334