knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
3 stars 19 forks source link

Backstage templates for Knative Functions #106

Closed aliok closed 1 month ago

aliok commented 1 month ago

TODO:

aliok commented 1 month ago

@pierDipi Code generation verification is not done in Prow jobs in other repos, right? Similarly, code generation verification is not done during a release in other repos?

pierDipi commented 1 month ago

Code generation verification is not done in Prow jobs in other repos, right?

Yes, that part is based on the existence of the hack/verify-codegen.sh file (which is not present in this repo), https://github.com/knative/hack?tab=readme-ov-file#using-the-presubmit-testssh-helper-script, point 2

Similarly, code generation verification is not done during a release in other repos?

no, it is done, this runs in the build tests job and those run before the release

knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [aliok,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aliok commented 1 month ago

/override "Code Style / style / Golang / Lint"

knative-prow[bot] commented 1 month ago

@aliok: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/106#issuecomment-2428685847): >/override "Code Style / style / Golang / Lint" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aliok commented 1 month ago

/override "style / Golang / Lint"

knative-prow[bot] commented 1 month ago

@aliok: Overrode contexts on behalf of aliok: style / Golang / Lint

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/106#issuecomment-2428686725): >/override "style / Golang / Lint" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.