search

knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
3 stars 17 forks source link

Do not de-duplicate event types #11

Closed aliok closed 7 months ago

aliok commented 7 months ago

Changes

-

-

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 7 months ago

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/11): >- Provider unit tests >- No more de-duplication of event types > > > > > ># Changes > > > >- >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
matzew commented 7 months ago

Is this related to the grouping we discussed?

aliok commented 7 months ago

No, this gets rid of deduplication. I will experiment with grouping later.

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [aliok,matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment